TP-Docs
HTML5 Icon HTML5 Icon HTML5 Icon
TP on Social Media

Recent

Welcome to TinyPortal. Please login or sign up.

June 15, 2024, 03:21:57 AM

Login with username, password and session length
Members
Stats
  • Total Posts: 195,242
  • Total Topics: 21,223
  • Online today: 137
  • Online ever: 3,540 (September 03, 2022, 01:38:54 AM)
Users Online
  • Users: 0
  • Guests: 138
  • Total: 138

[Bug/Fix] Problems with new help system...

Started by Oldiesmann, January 16, 2006, 12:16:47 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Oldiesmann

Found a minor bug with TP in regards to the new help system...

The new help system generates URLs like .../index.php?action=help;page=index

However, because TP just checks for a "page", you get errors:

QuoteYou have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'index AND off=0 AND approved=1 LIMIT 1' at line 1
File: /.../Sources/TPortal.php
Line: 313

It's an easy fix though...

Sources/TPortal.php

Find
// view single article?
$mypage='';
if(isset($_GET['page'])){


Replace
// view single article?
$mypage='';
if(isset($_GET['page']) && !isset($_REQUEST['action'])){

feline

that is only in TP 0.75 .. and that is not a bug of TP .. it's incompatibility to new RC2.

Fel

Oldiesmann

I'm running TP 0.8, so it's not just an issue with 0.75. I see it as a bug because SMF generally isn't coded to be completely compatible with existing mods...

IchBin

What are you doing over here Oldiesmann? Get back to work on SMF+G2!!! j/p :P

Oldiesmann

I will get back to work on that when I have more time to work on it... I've been extremely busy lately :)