Any plans on making TinyPortal ready for SMF 2.1?

[illori]

Now I can switch the Editor on and off I have been testing some layout questions I had: in the new TP articles I noticed that the style elements I use to in my articles do not show the same layout as before.

I cannot seem to resolve the issue.

What I see is that the style elements I was used to from the standard SMF css do not seem to work in Articles anymore.

Mostly the layouts for paragraphs < p> < /p> and lists < ol> ( ul> are not shown in the usual styles anymore.

For comparison, check this article:

In SMF 2.0.11 with TP 1.2
http://www.fjr-club.nl/index.php?page=8

In SMF 2.1 with TP 2
http://test.fjr-club.nl/index.php?page=8

seems the css in SMF 2.1 is giving you issues. not really a TP issue.

Code Select Expand

ul, ol {
list-style: none outside none;
}

[@rjen]

I am not sure.  The style in forum topics is unchanged and the list item are showing as they were in 2.0.11. only in the TP articles it seems changed...

[@rjen]

You are right that the css for 2.1 causes this.

I commented out this section:

Code Select Expand


/* <p> is a possible exception for margins. Must test that one a bit.
p, ul, ol, li, dl, dd ,dt, fieldset, form {
box-sizing: border-box;
padding: 0;
margin: 0;
}

/*ul, ol {
list-style: none;
}
*/

and now the articles in TP display as they did before...

You may just pay some attention to this change and what it means for TP users: it 'breaks' the layout in articles for anyone who will upgrade to the new TP version and SMF 2.1.

As a result I will have to 're-write' alle my articles, and to be honest: re-creating the bullited lists that I used cannot be done in TP articles unless I manually change the TP CSS file. Is that the desired setup?

[illori]

that is in the index.css file right? that is not in the tp css file at all.

the SMF devs decided that code was needed nothing to do with TP.

[@rjen]

Correct it is in index.css.

And you are right. It is not caused by any change in TP. Unfortunately it does affect the way TP content will be displayed in the future.

So how do future TP users recreate a bulleted list in TP 2.0?

[illori]

maybe if the list is in a div that css would not apply?

[illori]

as per http://www.simplemachines.org/community/index.php?topic=412286.0

i have changed most of the errors to fatal_lang_error and not logging to the error log. please test and report any issues. this also fixes the download area error and having it visible in the profile drop down.

[@rjen]

as per http://www.simplemachines.org/community/index.php?topic=412286.0

i have changed most of the errors to fatal_lang_error and not logging to the error log. please test and report any issues. this also fixes the download area error and having it visible in the profile drop down.

Thanks for the quick reply Illori!

I just reinstalled TP with the latest code base and did some tests. No problems with languages, but I am afraid the on/off in the member profile does not work yet (or maybe I am missing something)

Based on the module settings in de TP admin section I was expecting the menu option to be there or not to be there (see attachments) is my assumption correct that there is no change regardless of these settings?

[illori]

are you sure you have the updated files for all in place? this seems to work correctly for me.

https://github.com/Tinyportal/TinyPortal-SMF2.1/blob/TP2.1/Sources/TPassimilate.php#L154 and the line following control showing it in the menu.

[@rjen]

That's the same I have. So the download manager option is gone. That's good.

However, when I switch the download manager back on, I was expecting the old menu option to come back... and that it does not...